[COMPLETE] Gem Mining chance

[Nikki_Demise]

[COMPLETE] Gem Mining chance

Stumbled across this. According to this reference Gems should be 6x easier to mine than they are now.



http://www.uoguide.com/Five_on_Friday_-_August_10,_2007


"With the changes to mining, have the chances of mining up gems changed at all? What *are* the chances for mining gems, anyway?"
Mining for gems is not affected by this change at all, nor is lumberjacking for the special items (bark, amber, etc).
Gems have a flat chance of being mined up on each successful mining attempt. The gem type is totally random - it's not affected by the underlying ore type. You have a 0.6% chance of mining up a gem, with an equal chance of getting any of the six gem types.



Fix

Index: Scripts/Engines/Harvest/Mining.cs
===================================================================
--- /Engines/Harvest/Mining.cs    (revision 321)
+++ /Engines/Harvest/Mining.cs    (working copy)
@@ -114,13 +114,13 @@
             {
                 oreAndStone.BonusResources = new BonusHarvestResource[]
                 {
-                    new BonusHarvestResource( 0, 99.8998, null, null ),    //Nothing    //Note: Rounded the below to .0167 instead of 1/6th of a %.  Close enough
-                    new BonusHarvestResource( 100, .0167, 1072562, typeof( BlueDiamond ) ),
-                    new BonusHarvestResource( 100, .0167, 1072567, typeof( DarkSapphire ) ),
-                    new BonusHarvestResource( 100, .0167, 1072570, typeof( EcruCitrine ) ),
-                    new BonusHarvestResource( 100, .0167, 1072564, typeof( FireRuby ) ),
-                    new BonusHarvestResource( 100, .0167, 1072566, typeof( PerfectEmerald ) ),
-                    new BonusHarvestResource( 100, .0167, 1072568, typeof( Turquoise ) )
+                    new BonusHarvestResource( 0, 99.4, null, null ),    //Nothing
+                    new BonusHarvestResource( 100, .1, 1072562, typeof( BlueDiamond ) ),
+                    new BonusHarvestResource( 100, .1, 1072567, typeof( DarkSapphire ) ),
+                    new BonusHarvestResource( 100, .1, 1072570, typeof( EcruCitrine ) ),
+                    new BonusHarvestResource( 100, .1, 1072564, typeof( FireRuby ) ),
+                    new BonusHarvestResource( 100, .1, 1072566, typeof( PerfectEmerald ) ),
+                    new BonusHarvestResource( 100, .1, 1072568, typeof( Turquoise ) )
                 };
             }

 

[osd_daedalus]

Re: Gem Mining chance

That's good! I wonder, though, if chances to get a ML reagent from lumberjacking or fishing are always 0.6%

 

[uome]

Re: Gem Mining chance

That's good! I wonder, though, if chances to get a ML reagent from lumberjacking or fishing are always 0.6%

Looks like it.
http://www.uoguide.com/Gems

 

[Subjazz]

Re: Gem Mining chance

Fishing up pearls would be cool
but for now only good as decor

 

[osd_daedalus]

Re: [CODER NEEDED] Gem Mining chance

I think it's already implemented since SVN 333

 

[psz]

Re: [CODER NEEDED] Gem Mining chance

I know the pearls are in, but what about the mining?

 

[LadyCrimson]

Re: [CODER NEEDED] Gem Mining chance

I'm setting this to validation needed as I do not want to go strictly from UOGuide. Can we please find a link to this FOF that is referenced on an official UO site?

Once validation with an official link or OSI testing is done, then the fix can go to a testing status.

 

[osd_daedalus]

Re: [VALIDATION NEEDED] Gem Mining chance

I know the pearls are in, but what about the mining?

as I said, implemented in SVN 333. Mining and Fishing were fixed (if you read TortoiseSVN log, it's in SVN 332)

I'm setting this to validation needed as I do not want to go strictly from UOGuide. Can we please find a link to this FOF that is referenced on an official UO site?

Ok, here is it: http://www.uo.com/fof/fiveonfriday73.html

 

[LadyCrimson]

Re: [VALIDATION NEEDED] Gem Mining chance

Merci - setting to TESTING status.

 

[osd_daedalus]

Re: [VALIDATION NEEDED] Gem Mining chance

Merci - setting to TESTING status.

errr... how shall we test it? Fishing/mining 10k times in OSI and Demise and seeing if chances are equal?

Tortoise log says me, from SVN 331 to 332...

Fishing.cs was modified this way:

Index: Fishing.cs
===================================================================
--- Fishing.cs    (revision 331)
+++ Fishing.cs    (revision 332)
@@ -91,6 +91,15 @@
             fish.Resources = res;
             fish.Veins = veins;
 
+            if ( Core.ML )
+            {
+                fish.BonusResources = new BonusHarvestResource[]
+                {
+                    new BonusHarvestResource( 0, 99.4, null, null ), //set to same chance as mining ml gems
+                    new BonusHarvestResource( 80.0, [COLOR=Red].6[/COLOR], 1072597, typeof( WhitePearl ) )
+                };
+            }
+
             m_Definition = fish;
             Definitions.Add( fish );
             #endregion

the .6 mean the chance to get a pearl - 0.6%

and Mining.cs this way:

Index: Mining.cs
===================================================================
--- Mining.cs    (revision 331)
+++ Mining.cs    (revision 332)
@@ -114,13 +114,13 @@
             {
                 oreAndStone.BonusResources = new BonusHarvestResource[]
                 {
-                    new BonusHarvestResource( 0, 99.8998, null, null ),    //Nothing    //Note: Rounded the below to .0167 instead of 1/6th of a %.  Close enough
-                    new BonusHarvestResource( 100, .0167, 1072562, typeof( BlueDiamond ) ),
-                    new BonusHarvestResource( 100, .0167, 1072567, typeof( DarkSapphire ) ),
-                    new BonusHarvestResource( 100, .0167, 1072570, typeof( EcruCitrine ) ),
-                    new BonusHarvestResource( 100, .0167, 1072564, typeof( FireRuby ) ),
-                    new BonusHarvestResource( 100, .0167, 1072566, typeof( PerfectEmerald ) ),
-                    new BonusHarvestResource( 100, .0167, 1072568, typeof( Turquoise ) )
+                    new BonusHarvestResource( 0, 99.4, null, null ),    //Nothing
+                    new BonusHarvestResource( 100, .1, 1072562, typeof( BlueDiamond ) ),
+                    new BonusHarvestResource( 100, .1, 1072567, typeof( DarkSapphire ) ),
+                    new BonusHarvestResource( 100, .1, 1072570, typeof( EcruCitrine ) ),
+                    new BonusHarvestResource( 100, .1, 1072564, typeof( FireRuby ) ),
+                    new BonusHarvestResource( 100, .1, 1072566, typeof( PerfectEmerald ) ),
+                    new BonusHarvestResource( 100, .1, 1072568, typeof( Turquoise ) )
                 };
             }

They are .1 (0.1%) because they are 6 kind of gems in total, so you have 0.6% to get a gem.

That's my proof it got implemented.

 

[uome]

Re: [TESTING] Gem Mining chance

Daeds right, its in allready.
Need to mark as complete.

 

[LadyCrimson]

Re: [TESTING] Gem Mining chance

well then even better.