[COMPLETE] Holiday Tree Will crash shard

[Erica]

[COMPLETE] Holiday Tree Will crash shard

Hmm Interesting Hi the Holiday Tree on SVN 332 that was updated crashes when you try to double click deed and just target outside house on ground heres the crash report on debug mode.
I know you can't add Holiday Tree outside house but was doing some testing cause players will eventually make this crash happen.

Server Crash Report
===================

RunUO Version 2.0, Build 3466.34897
Operating System: Microsoft Windows NT 6.1.7600 
.NET Framework: 2.0.50727.4016
Time: 7/29/2009 16:12:32
Mobiles: 3462
Items: 151251
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Server.Items.HolidayTreeDeed.EndPlace(Mobile from, HolidayTreeType type, Point3D loc) in c:\Program Files\RunUO SVN 338 Mondain's Legacy\Scripts\Items\Deeds\HolidayTreeDeed.cs:line 113
   at Server.Items.HolidayTreeDeed.Placement_OnTarget(Mobile from, Object targeted, Object state) in c:\Program Files\RunUO SVN 338 Mondain's Legacy\Scripts\Items\Deeds\HolidayTreeDeed.cs:line 105
   at Server.Targeting.Target.Invoke(Mobile from, Object targeted)
   at Server.Network.PacketHandlers.TargetResponse(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

Just tho i add it here cause its bad bug .

 

[Xavier]

Re: [TESTING] Holiday Tree Will crash shard

This bug was originally snatched up and moved to the staff area so as to not give anyone any rotten ideas. The reality is that this bug only affects trees placed by staff, as that is the only way to override the placement rules, so its back here.

The problem arises when a GM places the tree outside of a house, the tree script searches for a housing region to add itself into as an addon, but does not check to see if it actually FOUND a housing region before trying to attach the addon.

Attached is a one-liner to fix it.

 

[LadyCrimson]

Re: [TESTING] Holiday Tree Will crash shard

This was already tested staff side and should be in the READY status.