Re: lumberjack bonus question
First off I would like to thank everyone for their efforts in understanding the Lumberjacker, the information provided here was very useful.
Now I have seen the BaseWeapon.cs code in the RunUO distro files. I know how the "distribution" LJing bonus works for both AoS and pre. Basically the default settings results in: (note: AoS and Pre AoS get these results via different methods, but both return the same results)
from 0.1 to 99.9
( player LJing skill * 20% ) which at 99.9 results in a 19.98% bonus. So for a 30 damage hit you would gain 19.98%, or 5.994 damage, for a total damage of 35.994 damage.
at GM ljing:
( player LJing skill * 20% ) which at 100 results in a 20% bonus, Then at GM you gain a 10% additional bonus. So for a 30 damage hit you would gain 30%, or 9 damage, for a total damage of 39 damage.
Below are code samples to validate this information.
AoS:
Code:
double lumberBonus = GetBonus( attacker.Skills[SkillName.Lumberjacking].Value, 0.200, 100.0, 10.00 );
if ( Type != WeaponType.Axe )
lumberBonus = 0.0;
Code:
public virtual double GetBonus( double value, double scalar, double threshold, double offset )
{
double bonus = value * scalar;
if ( value >= threshold )
bonus += offset;
return bonus / 100;
}
which with the proper number plugged in results in this:
Code:
public virtual double GetBonus( double value(100.0), double scalar(0.200), double threshold(100.0), double offset(10.00) )
{
double bonus = 100 * 0.200;
if ( 100.0 >= 100.0 )
bonus += 10.00;
return bonus / 100;
}
This basically calculates 20% of the players LJing skill, and multiplies the damage being delt by that 20% as long as the person is carrying an axe. however thanks to this section of code:
Code:
if ( 100.0 >= 100.0 )
bonus += 10.00;
if the person has GM LJing skill or over they recieve an additional 10% LJing bonus.
Pre AoS:
Code:
/* Compute lumberjacking bonus
* : 1% bonus for every 5 points of lumberjacking
* : +10% bonus at Grandmaster or higher
*/
double lumberBonus;
if ( Type == WeaponType.Axe )
{
double lumberValue = attacker.Skills[SkillName.Lumberjacking].Value;
lumberBonus = (lumberValue / 5.0) / 100.0;
if ( lumberValue >= 100.0 )
lumberBonus += 0.1;
}
else
{
lumberBonus = 0.0;
}
So basically this line of code:
Code:
lumberBonus = (lumberValue / 5.0) / 100.0;
does lumberjacking skill (lets say 80) divided by 5 then devide the sum by 100:
(80 / 5) / 100 which equals 0.16 damage bonus (or 16%)... Then this line checks to see if your LJing skill is GM, and if so adds an additional 10% damage bonus:
Code:
if ( lumberValue >= 100.0 )
lumberBonus += 0.1;
So if you are GM Ljing your bonus will be (100 / 5) / 100 which equals 20% damage bonus plus the additional 10% damage for being GM which equals 30% overall damage. So if a LJer takes a swing at GM LJing and deals 30 damage he will end up hitting for 39 damage. The only difference between the AoS and Pre AoS methods is that AoS is an exact 20% cut of the LJing skill, while Pre AoS gives LJing bonus in 5.0 skill increments.
So in conclussion, assuming that LJing bonus is identical to the RunUO Distrobution files (which may or may not be the case) Your LJing bonus is a percentage of your LJing skill that caps at 30% damage increase at GM, but at the low levels you are talking about the bonus is statistically insignificant( (0.3 / 5) / 100 = 0.06% damage increase ) I hope this helps clear things up!
