SVN 352 Update (August 1st, 2009)

psz · Aug 2, 2009

SVN 352 Update (August 1st, 2009)

Again, stolen from Xavier:

1) StormGrips GTOT should be ninja mitts, not leather gloves. Serialization is responsible for updating the existing grips' class to ninja mitts.

See: http://www.uodemise.com/forum/showthread.php?t=120441

2) Ethereal mounts had the wrong cast time. Post-AOS vet ethys should be 3 seconds, donation ethy time should be 7.5 seconds longer, and pre-AOS ethys were reduced to 2 seconds, since we could not collectively come up with the exact time they were.

See: http://www.uodemise.com/forum/showthread.php?t=120896

3) Greater Dragons should re-animate as Skel dragons with the necro spell.

See: http://www.uodemise.com/forum/showthread.php?t=121212

4) Crafting Leather Sleeves required too much materials. The requirement is lowered to 4 pieces of leather.

See: http://www.uodemise.com/forum/showthread.php?t=121014

5) Region data is updated to improve/correct various logout locations as well as the addition of several Mondain's Legacy regions.

See: http://www.uodemise.com/forum/showthread.php?t=119245

6) Divine Countenance was not repairable. This patch corrects that.

See: http://www.uodemise.com/forum/showthread.php?t=119926

7) Casting invisible on a player should toggle the target out of war mode. This patch corrects this.

See: http://www.uodemise.com/forum/showthread.php?t=119279

8) Typo corrected which gave lesser hiryus positive karma.

See: http://www.uodemise.com/forum/showthread.php?t=121165

9) Staff placing holiday trees outside of a housing region will now cause the server to crash due to a null pointer. This patch corrects the problem.

See: http://www.uodemise.com/forum/showthread.php?t=121420

10) Minor Champ Spawn Tweak

11) Guild Rosters now show who's online properlly.

Let it Die · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Thank You!

L I D.

Sly-demise · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Great job

Locarno · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

psz;596225 said:
2) Ethereal mounts had the wrong cast time. Post-AOS vet ethys should be 3 seconds, donation ethy time should be 7.5 seconds longer, and pre-AOS ethys were reduced to 2 seconds, since we could not collectively come up with the exact time they were.
See: http://www.uodemise.com/forum/showthread.php?t=120896

I assume, an ethy horse is pre-aos, a polar bear post-aos. I tried both and both have a cast time of 2 seconds.
What do I dont understand? Or what went wrong?

4) Crafting Leather Sleeves required too much materials. The requirement is lowered to 4 pieces of leather.
See: http://www.uodemise.com/forum/showthread.php?t=121014

yay!

10) Minor Champ Spawn Tweak

No more infos about that? How minor? AWs now on reptile spawn?

osd_daedalus · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Locarno;596281 said:
I assume, an ethy horse is pre-aos, a polar bear post-aos. I tried both and both have a cast time of 2 seconds.
What do I dont understand? Or what went wrong?

I believe something went wrong. The line in Ethereals.cs say:

Code:

return TimeSpan.FromSeconds( ((m_Mount.IsDonationItem && RewardSystem.GetRewardLevel( m_Rider ) < 3)? ( 7.5 + ( Core.AOS ? 2.0 : 3.0)) : ( Core.AOS ? 2.0 : 3.0)) );

I think the fact is that Core.AOS that was meant to say "if the ethereal is a AOS thing put 2, otherwise put 3"... but I suspect now it's saying "if the expansion is AOS or over (because ML includes AOS), put 2, otherwise put 3".
So, now it's "from AOS and over (SE, ML), put 2 seconds. Before it, put 3 seconds".

If it wasn't mean to do this, it is a bug.

If the intention was "in ML is 3, before is 2", then it was better !Core.ML instead of Core.AOS.
If it was "For AOS vet rewards (horses) put 2, for post-AOS vet rewards put 3"... no idea

[/quote]

Locarno;596281 said:
No more infos about that? How minor? AWs now on reptile spawn?

I have just seen 2 new lines in deserialize.

Code:

        public override void Deserialize( GenericReader reader )
        {
            base.Deserialize( reader );

            m_DamageEntries = new Dictionary<Mobile, int>();

            int version = reader.ReadInt();

            switch( version )
            {
                case 5:
                {
                    int entries = reader.ReadInt();
                    Mobile m;
                    int damage;
                    for( int i = 0; i < entries; ++i )
                    {
                        m = reader.ReadMobile();
                        damage = reader.ReadInt();

[COLOR=Red]                        if ( m == null )
                            continue;[/COLOR]

                        m_DamageEntries.Add( m, damage );
                    }

                    goto case 4;

I think it's just a minor glitch that went fixed.

New Deity · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

more details about champ spawn tweaks

Feersum Endjinn · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

psz;596225 said:
...a null pointer

Is that one of those stingingly fast Fencing weapons used by teachers?

Thanks for another great update.

FE

LadyCrimson · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

The ethies are not if they were available before or after AOS, it is the server. All ethies on the server have the same cast time. If they are using CORE AOS or later, then its 3. If they set up their server to be preAOS, then its 2.

Xavier · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Ya, the ethy time is another stupid typo no one noticed. AOS ethys are 3 sec, and pre-aos are less than 3, we are assuming 2

Pont · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

psz;596225 said:
2) Ethereal mounts had the wrong cast time. Post-AOS vet ethys should be 3 seconds, donation ethy time should be 7.5 seconds longer, and pre-AOS ethys were reduced to 2 seconds, since we could not collectively come up with the exact time they were.

See: http://www.uodemise.com/forum/showthread.php?t=120896

LadyCrimson;596431 said:
The ethies are not if they were available before or after AOS, it is the server. All ethies on the server have the same cast time. If they are using CORE AOS or later, then its 3. If they set up their server to be preAOS, then its 2.

SRC Xavier;596447 said:
Ya, the ethy time is another stupid typo no one noticed. AOS ethys are 3 sec, and pre-aos are less than 3, we are assuming 2

LC: So are you saying that older ethies on the server will cast at 2 seconds and newer ones 3, regardless of type? So an older horse could be 2 seconds and a newer one 3? Is that what you are trying to say?

Xavier: So is the 3 second vs 2 second thing a 'stupid typo' or were they made to be that way as psz said since no one could come up with the exact time?

LadyCrimson · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

No... I'm saying since we run an a CORE greater than AOS, all ethies will have the same cast time. someone who chooses preAOS as a core to their server will get the 2 seconds.

Pont · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

LadyCrimson;596577 said:
No... I'm saying since we run an a CORE greater than AOS, all ethies will have the same cast time. someone who chooses preAOS as a core to their server will get the 2 seconds.

Ok, thanks. I get it now.

Xavier · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Pont;596573 said:
Xavier: So is the 3 second vs 2 second thing a 'stupid typo' or were they made to be that way as psz said since no one could come up with the exact time?

2 and 3 got reversed.... next update they will be 3 seconds on our shard; 2 seconds on any Pre-AOS runuo shard.

The only thing we are unable to completely prove is the pre-aos summoning time, but we do know its LESS than the AOS change, hence 2 secs.

Pont · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

SRC Xavier;596619 said:
2 and 3 got reversed.... next update they will be 3 seconds on our shard; 2 seconds on any Pre-AOS runuo shard.

The only thing we are unable to completely prove is the pre-aos summoning time, but we do know its LESS than the AOS change, hence 2 secs.

Ok, thanks for the answer

.

Locarno · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Okay, summary:

All ethies on current official "OSI" shards have a cast time of 3 seconds.
Before AOS the cast time on official "OSI" shards had a cast time less than 3 seconds (2 are assumed).
So its not meant, that different types of ethies have different casting times (except donation ethies).
Demise should have casting times of 3 seconds for all vet ethies.
A typo is the reason that we have currently casting times of 2 seconds for all vet ethies.

Right?

Pont · Aug 2, 2009

Re: SVN 351 Update (August 1st, 2009)

Locarno;596669 said:
Right?

I think thats it.

technique · Aug 3, 2009

Re: SVN 351 Update (August 1st, 2009)

Thx , great job !

Nikki_Demise · Aug 4, 2009

Re: SVN 351 Update (August 1st, 2009)

osd_daedalus;596330 said:

I have just seen 2 new lines in deserialize.

Code:

        public override void Deserialize( GenericReader reader )
        {
            base.Deserialize( reader );

            m_DamageEntries = new Dictionary<Mobile, int>();

            int version = reader.ReadInt();

            switch( version )
            {
                case 5:
                {
                    int entries = reader.ReadInt();
                    Mobile m;
                    int damage;
                    for( int i = 0; i < entries; ++i )
                    {
                        m = reader.ReadMobile();
                        damage = reader.ReadInt();

[COLOR=Red]                        if ( m == null )
                            continue;[/COLOR]

                        m_DamageEntries.Add( m, damage );
                    }

                    goto case 4;

I think it's just a minor glitch that went fixed.

Was that done to fix a problem that occured? The only other place mobiles are added to that list is here which filters out nulls.

Code:

        public void RegisterDamage( Mobile from, int amount )
        {
            if( from == null || !from.Player )
                return;

            if( m_DamageEntries.ContainsKey( from ) )
                m_DamageEntries[from] += amount;
            else
                m_DamageEntries.Add( from, amount );
        }

If the deserialize tweak was needed I'd be quite interested in how nulls did or could work their way into the save files.

SVN 352 Update (August 1st, 2009)

psz

Administrator

Let it Die

Wanderer

Sly-demise

Sorceror

Locarno

Page

osd_daedalus

Knight

New Deity

Wanderer

Feersum Endjinn

Knight

LadyCrimson

Wanderer

Xavier

Account Terminated

Pont

Knight

LadyCrimson

Wanderer

Pont

Knight

Xavier

Account Terminated

Pont

Knight

Locarno

Page

Pont

Knight

technique

Page

Nikki_Demise

Bug Hunter