[COMPLETE] Remove Curse to work on spells it should

[osd_daedalus]

Re: Remove Curse to work on spells it should

Hoi,

the new way of implementation seems to work problemlessly.

Two things, thou:

1) Remove Curse drops a message 'You are no longer mortally wounede' whether one is wounded or not. That should be corrected.

For the truth, Remove Curse won't drop any message after removing Clumsy, Feeblemind... maybe it is not necessary to have a message for Mortal Strike.

2) I think it would be nice to drop some kind of message when a player is (succesfully) 'mind rottet'. What do you think? Any ideas?

I have found nothing in the cliloc, but if you really want to add something, you could use this:

1074384 : Your mind is attacked by psychic force!

Although it's not psychic force (Illithids, anyone?), it's really a curse.

 

[Nikki_Demise]

Re: Remove Curse to work on spells it should

Well, my suggestion was to add one. So the player knows he is hexed.

But if you all prefer a best possible OSI-clone, that is fine for me.

G.

It's not about what we prefer. I'd bet every single one of us have things we want to do different from OSI. However the staff of this shard has decided and PSZ has made clear that except for a few exceptions already outlined Demise game mechanics should be identical to OSI.

 

[gilgamash]

Re: Remove Curse to work on spells it should

Yes, thant is a nice one!

And here goes the zip-file.

Just unzip it within the 'Spells' subfolder; it should replace
the MindRot.cs file in the Necromancy subfolder and create a Util subfolder
with the necessary (new) classes.

And once again: Mobile.cs can remain unchanged!

Atb,
G.

Edit: Copy and Paste error... see next reply for the correct code

 

[gilgamash]

Re: Remove Curse to work on spells it should

corrected code...

 

[osd_daedalus]

Re: Remove Curse to work on spells it should

OK, I'll have a look tomorrow.

On a side note, I have just discovered an important fact:

If you apply the patch I provided on first post, it WON'T COMPILE, because you need also the Blood Oath buff fix. A sec that I'm updating the patch...

EDIT: all OK now. I have also touched the first Buff patch to exclude Blood Oath, since now it's here.

 

[osd_daedalus]

Re: Remove Curse to work on spells it should

Tested and it's PERFECT

No core mod required, works really well and effectively removes mindrot.

Approved

BTW, about UOGuide... since it's a wiki and we have a certain source about the effect of Remove Curse against Blood Oath... I edited that page

 

[osd_daedalus]

Re: Remove Curse to work on spells it should

Other bugs of minor importance, that I believe won't have so much impact to signal this bugreport as "not ready for commit"

Bug 1:

Hoi,

the new way of implementation seems to work problemlessly.

Two things, thou:

1) Remove Curse drops a message 'You are no longer mortally wounede' whether one is wounded or not. That should be corrected.

Now it's reporting to me "The Blood Oath has been broken". Looks like it remembers the last curse you got and, since that time, every time you cast Remove Curse you have the last system message about a particular curse removed.

Bug 2 (maybe associated with buffs):

It's normal or it's a bug... you have buffs only in ML? In pre-ML you don't have buffs. It was meant to be so?

 

[technocopter]

Re: Remove Curse to work on spells it should

so in short currently right now on demise, remove curse does removes blood oath, mindrot, corpse skin right?

 

[osd_daedalus]

Re: Remove Curse to work on spells it should

so in short currently right now on demise, remove curse does removes blood oath, mindrot, corpse skin right?

if you find it here, it's because it's NOT implemented yet (unless someone did and I don't know it).

When it will be implemented, you will read the [fixed] tag on the thread title.

Bye!

 

[psz]

Re: Remove Curse to work on spells it should

Is it at least READY at this point?

 

[gilgamash]

Re: Remove Curse to work on spells it should

@psz: I think it is, but the different parts comprising the patch need to be merged.

G:

 

[osd_daedalus]

Re: Remove Curse to work on spells it should

Is it at least READY at this point?

apart that little glitch, it's ready
We can try to fix those little things before server wars, but main functionalities are ready and they work.

 

[gilgamash]

Re: [Almost Ready] Remove Curse to work on spells it should

Ok, to clarify this (as it would be nice if it were integrated soon): The only things remaining
are those messages?

G:

 

[osd_daedalus]

Re: [Almost Ready] Remove Curse to work on spells it should

Ok, to clarify this (as it would be nice if it were integrated soon): The only things remaining
are those messages?

Yes, the fact Remove Curse repeats the message about the last curse removed.
So, if you removed Mortal Strike, you will always have the message you are not mortalled anymore; if you remove Blood Oath, you will always have the message the blood oath is broken...

 

[gilgamash]

Re: [Almost Ready] Remove Curse to work on spells it should

K, I'll care about this tonight. Can you PM me or send me a link to the files midifed by you already? Thanks,
G:

 

[osd_daedalus]

Re: [Almost Ready] Remove Curse to work on spells it should

K, I'll care about this tonight. Can you PM me or send me a link to the files midifed by you already? Thanks,
G:

I did nothing about, so you are free to go
Other files/mods are all in first post of this thread.

 

[Nikki_Demise]

Re: [Almost Ready] Remove Curse to work on spells it should

Didn't my fix for the mortal strike msg already get implimented?

 

[osd_daedalus]

Re: [Almost Ready] Remove Curse to work on spells it should

Didn't my fix for the mortal strike msg already get implimented?

You mean the fix to let Remove Curse work against mortal strike?

Yes, but now what happens is:

1) you suffer a mortal strike
2) you cast Remove Curse. You remove the mortal effect
3) After some time... you cast and you will have the system message "You are not mortalled anymore", even if you are not mortalled.

Same with Blood Oath. It's only a system message that repeats, nothing more.

 

[Nikki_Demise]

Re: [Almost Ready] Remove Curse to work on spells it should

You mean the fix to let Remove Curse work against mortal strike?

Yes, but now what happens is:

1) you suffer a mortal strike
2) you cast Remove Curse. You remove the mortal effect
3) After some time... you cast and you will have the system message "You are not mortalled anymore", even if you are not mortalled.

Same with Blood Oath. It's only a system message that repeats, nothing more.

No, The fix to make mortal strike removable wasn't mine, I made a fix to stop the msg if you weren't mortalled and thought it was already implemented.

 

[gilgamash]

Re: [Almost Ready] Remove Curse to work on spells it should

ah, so it is already all in the SVN. Good