osd_daedalus
Knight
[SVN] [Copern] code cleaning: scrolls of transc/105PS
situation at the moment: Our code quality sucks, but generally it's not really really bad.
in this report: in Scripts/Engines/CannedEvil/ChampionSpawn.cs I fixed the type of scrolls the protector should have, but in doing this I poorly written the part //Justice Reward 2 times, for 105PSes and Fel SoTs.
That IS horribile.
The risk I am going (and you are going too) to run is:
Note: no one bashed me for this specific one, it's an initiative of mine. That quoted phrase was about ToTs before the cleanup... but better taking it as a general rule.
situation at the moment: Our code quality sucks, but generally it's not really really bad.
in this report: in Scripts/Engines/CannedEvil/ChampionSpawn.cs I fixed the type of scrolls the protector should have, but in doing this I poorly written the part //Justice Reward 2 times, for 105PSes and Fel SoTs.
That IS horribile.
The risk I am going (and you are going too) to run is:
and being it already in the SVN... *gosh* :-P[2009-12-11 17:17:50] <@ASayre-> if you commit that to the svn I will hunt you down and attack you with a rusty spoon
Note: no one bashed me for this specific one, it's an initiative of mine. That quoted phrase was about ToTs before the cleanup... but better taking it as a general rule.