[SVN] Dog form HPR

[Sly-demise]

[SVN] Dog form HPR

This would require OSI testing for confirmation.

REQUIRED FIELDS:
Behavior on Demise: Dog form gives between 5-10 HPR at 120 Ninjitsu (visual estimation)
Behavior on OSI: Dog form might possibly give an HPR bonus equal to Ninjitsu/3 (40 HPR or 4 HP/second at 120 Ninjitsu)
Supporting Documentation (URLs): No official document but a Ninjitsu Guide from UOStratics forums.
http://vboards.stratics.com/showthread.php?t=44479
Code (optional): No clue

 

[Hilde]

Re: [VERIFICATION NEEDED] Dog form HPR

The code even has a comment on the regen rate for dog and cat animal forms:

Scripts/Misc/RegenRates.cs (66-68):

if ( CheckAnimal( from, typeof( Dog ) ) || CheckAnimal( from, typeof( Cat ) ) )
       points += from.Skills[SkillName.Ninjitsu].Fixed / 300;
//TODO: What's the new increased rate?

Should be easy to fix once it's validated

 

[MalGanis]

Re: [VERIFICATION NEEDED] Dog form HPR

With ninjitsu at 56.7 i transformed into a dog and a cat, both boosted hp regen rate by 18.

 

[Hilde]

Re: [CODER NEEDED] Dog form HPR

New patch:

• Your patch does not seem to use the right divisor. 56.7 / 30 would not be 18 Changed to 3.
• It has to be moved below the HPR cap, else you could not have a HPR of 27 (as you do in your screenshot)

 

[MalGanis]

Re: [TESTING] Dog form HPR

Your patch does not seem to use the right divisor. 56.7 / 30 would not be 18 Changed to 3.
It divides fixed value, meaning that actual skill value is multiplied with 10. So 567 / 30.

It has to be moved below the HPR cap, else you could not have a HPR of 27 (as you do in your screenshot)
Fixed.

 

[Hilde]

Re: [TESTING] Dog form HPR

Your patch does not seem to use the right divisor. 56.7 / 30 would not be 18 Changed to 3.
It divides fixed value, meaning that actual skill value is multiplied with 10. So 567 / 30.

I see. THX, didn't notice that

 

[uome]

Re: [TESTING-TC] Dog form HPR

This does seems to work as it should.

Tested:
At 56.7 ninjitsu i used animal form to go to dog form. I then set another char with 18 hpr in items and set both thier hits to 1hp.
Both charachters regened in hits at a very similar rate, both charachters were human and had 112 max hp.

I then set ninjitsu to 120 and spawned a paragon cow. I believe that paragons have an hpr of 40 and at 120 skill according to the link provided i should be getting an hpr of 40 from dog form.
I set both the cow and the player to 1 hp and watched them regen at a very similar rate.
Again i set the cow to 112 max hp so both were heading to the same target.

I tried all other ninjitsu forms and the cat and dog form are the only ones that give you the hit point regen.

I also tried polymorth using magery into a dog and you do not get any hpr increase.

The hpr from dog/cat form does stack with any hpr from items and the item cap seems unafected.

 

[Athena]

Re: [TESTING-TC] Dog form HPR

5 day timer

 

[Hilde]

Re: [TESTING-TC] Dog form HPR

I noticed a delay of about 1-2 seconds until the HPR kicks in when you are low on HP and cast the dog/cat form then. The HPR kicks in immediately when the player is already in dog form before he loses HP.

 

[uome]

Re: [TESTING-TC] Dog form HPR

Yeah i just noticed that too, it seems to wait until you gain your next hp before checking your form.

 

[Athena]

Re: [TESTING-TC] Dog form HPR

Setting back to in development until someone checks how it is on OSI.

 

[MalGanis]

Re: [IN DEVELOPMENT-TC] Dog form HPR

On osi you immediately start gaining hits faster.

 

[Hilde]

Re: [TESTING] Dog form HPR

I noticed something similar with the necro spell "Horrific Beast".

uoherald.com says the form gives 2HP/sec and not 20 HPR (of course 2HP/sec is 20HPR, but it's not capped at 18 and should be added to existing HPR). I added it to this patch as it's almost the same as Animal Form and is fixed at the same place in the script. It should also make applying the patch more easy. Please correct me if it's wrong or if I should make a new bug thread for this.

 

[uome]

Re: [TESTING] Dog form HPR

Hilde i can't get your patch to apply using tortoise.
"an unknown line type was found in line 5!"

 

[Hilde]

Re: [TESTING] Dog form HPR

Hilde i can't get your patch to apply using tortoise.
"an unknown line type was found in line 5!"

Ohh, I will look into it when I get home

 

[Hilde]

Re: [TESTING] Dog form HPR

Ohh, I will look into it when I get home

Or a bit later

New patch against the current svn revision (427).

 

[Hilde]

Re: [TESTING] Dog form HPR

I tested the HPR in dog form and cat form with different ninja skills. It seems all fine. The HP regeneration kicks in the moment you successfully cast the spell.

Also the HPR for horrific beast seems right, it just kicked in a moment to late because I forgot to include a file in the patch

Added a new patch.

 

[Pont]

Re: [TESTING] Dog form HPR

Tested - no problems found. Seems to be working A'ok.

 

[osd_daedalus]

Re: [TESTING] Dog form HPR

ready?

 

[osd_daedalus]

Re: [READY] Dog form HPR

Implemented in SVN 437