[SVN 529] Merged Arcane gem threads

[Pont]

Re: [CODER NEEDED] Blessed Arcane Clothing (AKA nerf me)

Can this be moved to testing please and possibly added to TC??? We have code to test above (#18).

 

[osd_daedalus]

Re: [TESTING] Blessed Arcane Clothing (AKA nerf me)

Tested on RunUO Private Distro, SVN 514

- made an exceptional robe, cloak, leather gloves and thigh boots. I made all of them arcane.
- Attempting to bless them with CBD results in a failure.
- the system message obtained is "you cannot bless that item" (in OSI should be "this bless deed is for Clothes only")

- I made another set of exceptional robe, cloak, leather gloves and thigh boots
- I used the CBD on them, except leather gloves which are not blessable
- I attempted to use arcane gems on the blessed robe, cloak and thigh boots. It always results in a failure.
- the system message obtained is "you cannot use the gem on that" (in OSI should be "you can only use this on exceptionally crafted robes, thigh boots, cloaks, or leather gloves")

Conclusions:

the desired effect works as intended, but system messages are not coherent with OSI.

Would be good to discover if it's only an issue of this, or if the whole failure messages are wrong/changed during expansions.

 

[Pont]

Re: [TESTING] Blessed Arcane Clothing (AKA nerf me)

Tested on RunUO Private Distro, SVN 514

- made an exceptional robe, cloak, leather gloves and thigh boots. I made all of them arcane.
- Attempting to bless them with CBD results in a failure.
- the system message obtained is "you cannot bless that item" (in OSI should be "this bless deed is for Clothes only")

- I made another set of exceptional robe, cloak, leather gloves and thigh boots
- I used the CBD on them, except leather gloves which are not blessable
- I attempted to use arcane gems on the blessed robe, cloak and thigh boots. It always results in a failure.
- the system message obtained is "you cannot use the gem on that" (in OSI should be "you can only use this on exceptionally crafted robes, thigh boots, cloaks, or leather gloves")

Conclusions:

the desired effect works as intended, but system messages are not coherent with OSI.

Would be good to discover if it's only an issue of this, or if the whole failure messages are wrong/changed during expansions.

I tested this on Demise TC too and found the same.

However, I also tried a clothing bless deed on other objects and got the message "You can't bless this object!". This may be another difference in what OSI gives that needs to be checked regarding the message a clothing bless deed gives on other objects and can be dealt with seperately.

Also using the arcane gems on other objects got the message "you cannot use the gem on that".

I'd recommend that this is a seperate bug issue due to failure messages being wrong/changed in later expansions as osd_daedalus mentioned and should be treated under a different bug thread as it not only relates to blessed clothing deeds but also arcane gems in general and maybe other items.

 

[osd_daedalus]

Re: [TESTING] Blessed Arcane Clothing (AKA nerf me)

I'd recommend that this is a seperate bug issue due to failure messages being wrong/changed in later expansions as osd_daedalus mentioned and should be treated under a different bug thread as it not only relates to blessed clothing deeds but also arcane gems in general and maybe other items.

But I want to be sure it's a generic problem of the message... do you get same message if you try, let's say, to use an arcane gem or a CBD on a fishing pole here and in OSI?
If yes, I can fix it really easy.
If not, maybe not so easily

 

[Bama]

Re: [TESTING-TC] Blessed Arcane Clothing (AKA nerf me)

Excuse the bad screen shots 7.0.7.1 + razor is not working well together for now on osi

Anyway here are the messages and when I was able to use the arcane gem I didn't get a message

 

[Bama]

[TESTING] Arcane Gems

Behavior on Demise:
First we must say thank-you to Barnicoat for his
help in providing demise items

100 lrc works with necro and uses charges from arcane robe, cloak, leather armor gloves (normal, spine, horned, and barbed) but not studded armor, and thigh boots (all has to be exceptional). That's 96 casted spells (with 120 tailoring) before you deplete them all. Keep at least 1 arcane gems with you at all times, you donna wa be stuck somewhere with no way out, unless you have recall charges in your rune book.

Being able to use arcane gems on items made from
spined/horned/barbed is not right
It is normal leather only
Item property line for arcane charges is in the wrong place

Behavior on OSI:
Thanks for the arcane gems IP

Normal leather only on OSI
You can't make normal leather gloves use the arcane gem and then try to enhance it either on OSI
Nor can you bless a cloak/robe with arcane charges or add arcane charges to a blessed robe/cloak
Arcane gems on Demise are bugged in a few different ways it seems

Supporting Documentation (URLs):
Changes needed:
Code (optional):
First 8 screen shots are demise

 

[Bama]

Re: Arcane Gems

Item property line

 

[Bama]

Re: Arcane Gems

A little more info

On osi when you use the arcane gem the item no longer carries the exceptional item property

Also if you look at the demise gloves you see the item keeps all its original resists
though on osi they lose resists to 15 total
(default to non-exceptional normal leather gloves without arms lore?)

I guess
Arcane gems on Demise are bugged in a few different ways it seems

 

[Kraz]

Re: Arcane Gems

More info needed, like:
If you apply the arcane gem to an item that is not "marked" (crafted by)... the item become marked or not?
Have you tested the craft -> gem with arms lore or not?
Blessed items can not recieve gems, right?

 

[Bama]

Re: Arcane Gems

More info needed, like:
If you apply the arcane gem to an item that is not "marked" (crafted by)... the item become marked or not?
Have you tested the craft -> gem with arms lore or not?
Blessed items can not recieve gems, right?

When I log on again to osi i will show the mark not marked
For the other questions
If you look at the screen shots and count resists you will see the extra arms lore resists on it before the gem is used
I show trying to use a gem on a bless robe and it does not work

 

[Kraz]

Re: Arcane Gems

Yes, about the clothing bless, it's related to this thread:
http://uodemise.com/forum/showthread.php?t=124776
Really shouldnt be able to use arcane gem on blessed items.

Another thing you should check is trying to enhance an arcane item, what is the message?

I think that I have a fix for those arcane gem stuff, when possible test the mark/unmarked.

 

[Bama]

Re: Arcane Gems

Yes, about the clothing bless, it's related to this thread:
http://uodemise.com/forum/showthread.php?t=124776
Really shouldnt be able to use arcane gem on blessed items.

Another thing you should check is trying to enhance an arcane item, what is the message?

I think that I have a fix for those arcane gem stuff, when possible test the mark/unmarked.

The message appears on the sewing kit menu as I tried to enhance using horned leather

If I make gloves or whatever and not mark them the name of the person who adds the arcane charges will appear on the gloves or whatever
so the persons skill corresponds to the amount of charges

 

[Kraz]

Re: Arcane Gems

EDIT: Posted the diff files above.

 

[Kraz]

Re: [TESTING-TC] Blessed Arcane Clothing (AKA nerf me)

There's another thread about that, I've posted the fixes there...
Including fixes on arcanegem.cs, enhance.cs, and messages according to OSI I guess.
http://uodemise.com/forum/showthread.php?t=149160

There's no point testing the blessed thing when you can apply gem after blessing.
Is there a way to merge or something?

 

[Bama]

Re: [TESTING-TC] Blessed Arcane Clothing (AKA nerf me)

There's another thread about that, I've posted the fixes there...
Including fixes on arcanegem.cs, enhance.cs, and messages according to OSI I guess.
http://uodemise.com/forum/showthread.php?t=149160

There's no point testing the blessed thing when you can apply gem after blessing.
Is there a way to merge or something?

Typo?

 

[psz]

Re: Arcane Gems

----------------------------------------------
Creating a new patch

Ok, you've probably noticed that your Scripts folder no longer has a green check mark on it. It's been replaced by a red exclamation point. This simply means that files on your RunUO are different than the ones found on the SVN. This is due to the patch you applied.

Now lets say you've found a problem with a sword. You notice that the Str requirement on OSI is 15, but on RunUO is 12. When you go in and fix that sword, it will show with the red exclamation mark. Simply right-click the sword's file, go to TortoiseSVN > Create Patch

You will get a window which shows the file you have edited. There will be two check boxes at the bottom. For this demonstration, you can leave them alone, or have them both checked (do not uncheck the bottom one). Hit OK, and you will be asked to give the new patch file a name.

Once it has it's name and is saved, you'll see a preview of the patch.

You can now upload the patch for others to try.


---------------------------------------------------
Creating a multi-file patch

**** IT IS HIGHLY RECOMMENDED THAT YOU DO NOT MAKE MULTI-FILE PATCHES ON ANYTHING BUT A VANILLA RUNUO-SVN****
Doing so otherwise may cause cross-patching with other updates.

(Please make the DIFFs ;->)

 

[Kraz]

Re: Arcane Gems

No problems, thing is I'm using Callandor2k SVN to test and... well I guess we wont have problems in this case.

 

[Barnicoat]

Re: Arcane Gems

More info needed, like:
If you apply the arcane gem to an item that is not "marked" (crafted by)... the item become marked or not?
Have you tested the craft -> gem with arms lore or not?
Blessed items can not recieve gems, right?

I can confirm that on Demise at least a non-marked item becomes marked when an arcane gem is used on it.

I don't have any screenshots, but just thought I'd add something.

Barn.

 

[Kraz]

Re: Arcane Gems

Yes and according to Bama's screenshots on OSI it's the same, if you apply the gem into a non-marked the item becomes marked.

 

[Marok]

Re: [TESTING-TC] Merged Arcane gem threads

In the TC it is currently applying the Maker's Mark to unmarked pieces, and none of the pieces can be blessed.