[SVN 662] Adding Salvage Bags

[Cedmon]

[TESTING-TC] Adding Salvage Bags

link to a handy bag that can be bought from a provisioner that would be helpful for the crafters of demise

http://www.uoguide.com/Salvage_Bag

 

[osd_daedalus]

Re: [CODER NEEDED] Adding Salvage Bags

There is a RunUO thread about this, so I have thought to signal you (as I am noticing them about this of course!)
http://www.runuo.com/forums/script-support/98322-salvage-bag.html

Here's some questions to answer:

* Unknown: At which skill level the ingot bonus will apply?
 * Unknown: Where do resources go after salvage process?
 *
 * Question: ...and any unused cloth left in the bag accidentally will be turned into bandages.
 *   According to UOGuide.com any cloth left in the bag will become bandages.So that means cloth and leather resources stay in the bag after the salvage process.
 *   Currently cloth and leather stay in the bag but ingots go to top of the bag.
 * Question : Does OSI allow for low level miners to successfully smelt every item?
 *   Currently If your mining skill is lower than 20.0 you won't going to smelt anything.
 *

 

[Phoenix_Smasher7]

Re: [CODER NEEDED] Adding Salvage Bags

Well if anyone can answer the questions above I'll try my best to add them in.

Current status:

Finished Context Menu so everything shows as it should be.
Finished Mining bonus.Though I've just set it to give +1 ingot when player has 60+ skill level in mining.

Edit:
Bag is currently done.Also cleaned the code up a bit.Waiting response from original author to be able to release it.

 

[Phoenix_Smasher7]

Re: [CODER NEEDED] Adding Salvage Bags

Well.I have the Varchild's permission.So here's the script.

Though still it lacks the answers of the questions above.So If you have the time to correct me up on OSI it would be appreciated.

 

[MalGanis]

Re: [CODER NEEDED] Adding Salvage Bags

Where do resources go after salvage process?
In players backpack (top level).

and any unused cloth left in the bag accidentally will be turned into bandages.
That is correct. Bandages also go in players pack (top level).

Does OSI allow for low level miners to successfully smelt every item?
Yes. I have 0 mining on my crafter and he still smelted every item.

 

[osd_daedalus]

Re: [CODER NEEDED] Adding Salvage Bags

perfect! So now we miss only to get the bonuses for mining skill, right?

 

[MalGanis]

Re: [IN DEVELOPMENT] Adding Salvage Bags

There doesnt seem to be any bonus. Also you can smelt looted items. They give double resources.

Example: looted short spear gave 4 ingots.
crafted short spear gave 2 ingots at GM mining.
crafted short spear gave 2 ingots at 0 mining.

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

theres only one ingot bonus currently for the bag and it comes after 60.0 mining.Ill remove the mining requirement from the bag now so everyone can smelt.
If i remember right if an item isn't player crafted you will only get 1 ingot from it.Even if it's plate chest.Is this how it's like in OSI?

 

[MalGanis]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Actually i think the base is 2 ingots (doesn't matter if its crafted or not).

If i buy chain tunic off a vendor, i always get 2 ingots regardless of my mining skill.

Now if its crafted, the amount of ingots scale with mining skill:
Chain tunic (requires 20 ingots to craft)
Mining - Ingots
0 - 2
10 - 2
20 - 3
30 - 4
40 - 6
50 - 7
60 - 8
70 - 10
80 - 11
90 - 12
100 - 14

Formula seems to be like this: 2 + ( Mining - 10 ) * ( ingot requirements - 2 ) * 0.0075 rounded down.

 

[osd_daedalus]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Actually i think the base is 2 ingots (doesn't matter if its crafted or not).

Now if its crafted, the amount of ingots scale with mining skill:
Chain tunic (requires 20 ingots to craft)
Mining - Ingots
0 - 2
10 - 2
20 - 3
30 - 4
40 - 6
50 - 7
60 - 8
70 - 10
80 - 11
90 - 12
100 - 14

Formula seems to be like this: 2 + ( Mining - 10 ) * ( ingot requirements - 2 ) * 0.75 rounded down.

Is this bonus valid also if you smelt items on a normal forge?

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

I don't think so.There's no exact mining check on my Resmelt.cs.

Also looted and imported items always yield 1 ingot no matter the skill.Same as OSI?

Also What about the resource skill checks?You can't smelt valorite items if you don't possess enough mining.

 

[MalGanis]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Is this bonus valid also if you smelt items on a normal forge?
Yes seems to be so, with one exception, you get 1 ingot if you have no mining, so
1 + ( Mining - 10 ) * ( ingot requirements - 1 ) * 0.0075 rounded down. Dunno why tho.

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Alright does bag makes you smelt items crafted by other resources while having 0 mining skill?If so it's a bug.

 

[MalGanis]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Nope it doesn't, says You failed to smelt some metal for lack of skill.

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Alright I'll be adding that too...

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Hmm..Will the bonus continue to apply over 100? Because you will be getting 17 ingots back from chainmail tunic made with 20 ingots.

Current status:
Skill check for materials...done.
Mining skill bonuses...done.
Resources go to top of the bag...done.

 

[MalGanis]

Re: [IN DEVELOPMENT] Adding Salvage Bags

You cant get over 100 (at least not to my knowledge).

 

[osd_daedalus]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Oh, just a thing:

this script would add salvage bags, but would be great if a patch that allows provisoners to sell them is done, so it can go straight in the Test Center.

Just remember provisoners should sell this only if the core expansion is set to ML

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Alright then restricting bonus to 100 and I'll try to patch provisioners so they will sell it.Is the price always same?

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] Adding Salvage Bags

Alright it seems all is done.

Provisioners sells this for 1225 gp.If it's not right,I'll update.

Resources are moved to backpack after salvage process.
Mining skill factors highly on the salvage process.(Not on tailoring of course )
No ingot bonus over 100 mining.

So that's all i guess.