[SVN] Embracing Honor

[das3]

Re: [CODER NEEDED] Embracing Honor

IMO there are still some open questions that need to be tested:

- Does Embrace honor work on faction mobs?
- How about the ethic system? (good vs evil)

I'd say it should work on every monster, but someone test this on OSI please.

 

[Muggz]

Re: [CODER NEEDED] Embracing Honor

It works against ALL mobs untill you go hostile on one. Then that mob and only that mob will attack you.

 

[das3]

Re: [CODER NEEDED] Embracing Honor

Figured as much.

Patch attached. Tested it on my local server, seems to do fine.

 

[Muggz]

Re: [TESTING] Embracing Honor

So anyone test this or can test this at all?

 

[Jacek.Kosiarz]

Re: [TESTING] Embracing Honor

have you took on eye this sentance from first link -
"If you defeat your target while at the highest level of perfection, you will regain some Hit Points, Stamina and Mana."
i dont think its working right now too.

 

[Muggz]

Re: [TESTING] Embracing Honor

have you took on eye this sentance from first link -
"If you defeat your target while at the highest level of perfection, you will regain some Hit Points, Stamina and Mana."
i dont think its working right now too.

Yes that works as it should, I have tested it before.

 

[Muggz]

Re: [CODER NEEDED] Embracing Honor

Figured as much.

Patch attached. Tested it on my local server, seems to do fine.

Ok since I have a few nights off I decided to test this tonight. The script locations are wrong in the patch BUT I went in and manually added the lines and everything seemed to work out.

 

[Muggz]

Re: [TESTING] Embracing Honor

If someone has access to test on OSI can they please test the following.

If you are under embrace honor and try taming a dragon and it becomes angered, does it attack you or still ignore you?

 

[Muggz]

Re: [TESTING] Embracing Honor

Ok tested taming a dragon while Embrace honor was active on OSI TC and it did not attack me when it was angered.

I think the check would be added to taming script in skills for this.

 

[das3]

Re: [TESTING] Embracing Honor

Ok tested taming a dragon while Embrace honor was active on OSI TC and it did not attack me when it was angered.

I think the check would be added to taming script in skills for this.

Rats' tail... *sigh* Personally I think that has been overlooked by OSI and shouldn't be patched on RunUO accordingly. Imagine taming a dog, fumbling and instead of baiting it with a bone sticking it up its arse. Hostile action. As the molested dog, I would *SO* know whose face to gnarl.

Anyway, since this is the main reason everyone wants this in and its per OSI... patch coming.

UPDATED: Attached the wrong patch file.

 

[uome]

Re: [TESTING] Embracing Honor

Compiling error

Errors:
 + Skills/AnimalTaming.cs:
    CS0103: Line 183: The name 'm' does not exist in the current context
    CS0103: Line 183: The name 'm' does not exist in the current context

 

[das3]

Re: [TESTING] Embracing Honor

Got it. Attached new patch. Tho you might want to check with mark/psz if the taming-part should go in. Still think it's a bug of OSI.

 

[uome]

Re: [TESTING] Embracing Honor

Tested on BAD tc. Seems to be working as described.

Checked:
When embracing honour all monsters willl ignore you, checked trammel and felucca, Champ spawns and non champ spawns, i also checked gauntlet and the creatures there leave you alone too.

When taming an animal and it becomes angry it wont attack you while you are embracing honour.

The duration is dependant on the amount of honor you have.

Players can still attack another player that is embracing honour.

If you attack a monster while embracing honour it will attack you, this does not break your embrace.

Question:
If you are being attacked by something and you embrace honor should the attack continue?
At the moment with this patch any monster attacking will continue to attack once honor is embraced. If this is how it works on osi then i would consider this ready.

 

[Muggz]

Re: [TESTING] Embracing Honor

When you embrace honor anything that was hostile to you before hand is still hostile.

 

[osd_daedalus]

Re: [READY] Embracing Honor

Implemented in SVN 444