[SVN] Skinning Knives to return you cut leather

[Athena]

Re: [TESTING] Skinning Knives to return you cut leather

This needs updating to work with the latest SVN, setting back to development until a new patch is provided.

 

[osd_daedalus]

Re: [IN DEVELOPMENT] Skinning Knives to return you cut leather

Here you are

 

[surgat]

Re: [TESTING-TC] Skinning Knives to return you cut leather

Not working right.

Tried it 5 minutes ago, and this is what I got:
- had swords of prosperity equiped, double clicked skinning knife on backpack, got cut barbed leather on bag (killed that ww that spawns in the test area). Scales and meat remained on corpse.
- was with both hands free (not holding any weapon, or shield, or anything) and double clicked skinning knife on backpack, got cut barbed leather on bag (ww again). Scales and meat remained on corpse.
- holding SOP again, did the same thing, but this time on a dead hiryu. Got cut leather on bag. Meat remained on corpse.


Results: Skinning knife doesnt have to be equiped. It will work no matter what you are holding on your hand.

 

[osd_daedalus]

Re: [TESTING-TC] Skinning Knives to return you cut leather

Try this one then

As per I.P.Knightly findings, you have cut-up leather even if you use another bladed item in backpack, if skinning knife is equipped.

To expert coders and QC czars: I have left the reference to item "with" in Corpse.cs because it will be useful when the Butcher War Cleaver will be coded (already coded and commented out with a TODO )

 

[I.P.Knightly]

Re: [TESTING-TC] Skinning Knives to return you cut leather

I think I got the system message for most of the screen shots

 

[osd_daedalus]

Re: [TESTING-TC] Skinning Knives to return you cut leather

so, what must be added (in the future) is also "return cut leather if butcher war cleaver is equipped and you use another thing". The rest seems OK to my patch.

Just a sec I'll post a new patch (it's just a commented out thing)

edit: here it is.
If you don't want to patch again, just edit the line in BaseCreature.cs this way:

                    if ( Core.AOS && ( holding is SkinningKnife /* TODO: [COLOR=Red]|| holding is ButcherWarCleaver || with is ButcherWarCleaver[/COLOR] */ ) )

 

[Athena]

Re: [TESTING-TC] Skinning Knives to return you cut leather

TC updated.

 

[Athena]

Re: [TESTING-TC] Skinning Knives to return you cut leather

I have tested this on Demise TC, if I have the skinning knife equipped I am able to cut corpses and have the leather put in my backpack either directly using the skinning knife or if I use a bladed item from my backpack.

If the skinning knife is not equipped the hides go to the corpse as usual.

Any scales or ribs etc remain on the corpse.

There is a 2 tile check for carving the corpse.

If I try to carve a corpse that I have no looting rights on in Trammel I get the message "You did not earn the right to loot this creature!". If I do this in Felucca I get the cut up leather in my pack and it's a criminal act.

All of the relevant system messages appear to be right.

This patch is good to go.

 

[Xavier]

Re: [READY] Skinning Knives to return you cut leather

In SVN 495