[SVN 535] Different sized ore & combining

[Bama]

Re: [TESTING-TC] [uome] Different sized ore & combining

The amount of ore is not correct
I was getting more ore then I should have
For humans
1 ore in non Felucca facet with a chance for 2 ore
2 ore in Felucca facet with a chance for 3

I was getting the bonus on every swing of the pick axe (100 times) in both facets

 

[uome]

Re: [TESTING-TC] [uome] Different sized ore & combining

I tested
In non-Felucca facets I was getting 2 ore no matter the size per mining attempt
In Felucca I was getting 3 ore no matter the size per mining attempt

Even though I was using a human character the odds of me getting the ore bonus on every attempt though possible is very very high
I used a pick axe with 50 uses in each facet Tram and Felucca

I think this is the way it works in Demise atm and is covered as a seperate issue in another thread.
http://www.uodemise.com/forum/showthread.php?t=119595

 

[Bama]

Re: [TESTING-TC] [uome] Different sized ore & combining

I think this is the way it works in Demise atm and is covered as a seperate issue in another thread.
http://www.uodemise.com/forum/showthread.php?t=119595

Well I can tell you from what I know on osi
non-Fellucca facet it is 1 ore with the chance to get 2
Fellucca it is 2 ore with the chance to get 3
The chance is I believe a 10% chance to get the bonus per swing
See now I see why whenever something is changed to match osi the demise community screams nerf
If it is the norm for human miners to mine up 2 in non Fellucca and 3 in Felucca you are going to have some very upset miners on your hands because that is wrong

Anyway Dee Lynn Quint is human and if where she is mining was demise she should have dug up 4 ore not the 2 she did
Someone in that link said they wanted 1000 digs for validation I think they can go do it if it means that much to them

 

[Bama]

Re: [TESTING-TC] [uome] Different sized ore & combining

26 digs before I got the bonus of 2 ore on 1 swing

 

[uome]

Re: [TESTING-TC] [uome] Different sized ore & combining

There is a new patch in the first post with the human bonus harvest amount corrected to a 10% chance. The only reason i never tried to fix that before is my lack of coding skill
Anyway give this atry and see if it works.

 

[Bama]

Re: [TESTING-TC] [uome] Different sized ore & combining

Aside from the fact that the wrong amount of ore is dug up there is one other problem
Smelting the small ore size.The size where 2 ore gives you 1 works correctly when smelting even amounts.When you smelt 3 or 5 or 7 or 9 you get the picture this patch does not smelt those size ore as per osi

Demise:
3 of the small ore gives 1 ingot and the left over ore ( remember you need 2 to get 1 ingot) disappears

OSI:
3 of the small ore gives 1 ingot and the left over ore ( remember you need 2 to get 1 ingot) remains where you smelted from
Screen shots

 

[uome]

Re: [IN DEVELOPMENT] [uome] Different sized ore & combining

There is a new patch in the first post which i hope will address all the known issues.
Sorry it's taken me so long to figure it out.

 

[Callandor2k]

Re: [IN DEVELOPMENT] [uome] Different sized ore & combining

There is a new patch in the first post which i hope will address all the known issues.
Sorry it's taken me so long to figure it out.

I get a warning in Ore.cs

Warnings:
+ Items/Resources/Blacksmithing/Ore.cs:
CS1717: Line 353: Assignment made to same variable; did you mean to assign s
omething else?

Here is the block of code...

else
{
amount = amount;
m_Ore.Delete();
}[FONT=Consolas][SIZE=2]
[SIZE=2][FONT=Consolas]　[/FONT][/SIZE]
[SIZE=2][FONT=Consolas]ingot.Amount = amount;[/FONT][/SIZE]
[SIZE=2][FONT=Consolas]from.AddToBackpack( ingot );[/FONT][/SIZE]
[/SIZE][/FONT]

Shouldn't it state this....

else
{
ingot.Amount = amount;
m_Ore.Delete();
}[FONT=Consolas][SIZE=2]
[SIZE=2][FONT=Consolas]　[/FONT][/SIZE]
[SIZE=2][FONT=Consolas]from.AddToBackpack( ingot );[/FONT][/SIZE]
[/SIZE][/FONT]

Or did I miss something?

 

[uome]

Re: [IN DEVELOPMENT] [uome] Different sized ore & combining

I get a warning in Ore.cs

Shouldn't it state this....

else
{
ingot.Amount = amount;
m_Ore.Delete();
}[FONT=Consolas][SIZE=2]
[SIZE=2][FONT=Consolas]　[/FONT][/SIZE]
[SIZE=2][FONT=Consolas]from.AddToBackpack( ingot );[/FONT][/SIZE]
[/SIZE][/FONT]

Or did I miss something?

Yeah now you point it out it does look very silly.
This is why it's taken me so long to figure out. I will stick to easier patches in the future i'm just determined to get this one finished even if it takes the rest of time.
Odd that i never saw any warning on my console.

Hmm seems that didnt work as expected so i have done this instead:

else
{
    amount /= 1;
    m_Ore.Delete();
}

ingot.Amount = amount;
from.AddToBackpack( ingot );

Here is the new patch anyway.
Thanks for the help Callandor2k.

RAWR I had to remove evil orc helm change remants from this patch file -Xavier

Oops, sorry

 

[Callandor2k]

Re: [IN DEVELOPMENT] [uome] Different sized ore & combining

Yeah now you point it out it does look very silly.
This is why it's taken me so long to figure out. I will stick to easier patches in the future i'm just determined to get this one finished even if it takes the rest of time.
Odd that i never saw any warning on my console.

Hmm seems that didnt work as expected so i have done this instead:

else
{
    amount /= 1;
    m_Ore.Delete();
}
 
ingot.Amount = amount;
from.AddToBackpack( ingot );

Here is the new patch anyway.
Thanks for the help Callandor2k.

I purposely cause a simple error in a script to check for any warnings. I never tested what I put up as a replacement. I just threw something out there off the top of my head. And now that you put what you replaced it with. It makes more sinse to do it the way you have it.

 

[Bama]

Re: [TESTING-TC] Different sized ore & combining

This works well
The stacking and the smelting is as osi