[SVN 672] Honour Virtue Bugs

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

i just looked over the demise honor values. 4.5 honor for an ettin with a warrior (compared to around 30 on osi.)
and 114 with a daemon, and 150 or so on osi.
I think we could suggest that the fix is an urgent one to players who like pvm.
Ill propose a new system tonight.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

even though the fame level decreases over time, the amount of honor gained doesnt. it is only affected by the players current honor.

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

i didnt let the archer walk around. the only honor rule i broke was the first hit rule. Could try this again with a mage, let the monsters have first hit, then FS them. I reckon it will gain in 15 kills, maybe less.
then we need to try a tamer.

My bard was not getting hit first (never got hit by the honor target) and was moving and hiding.Yet it gained in honor like your archer

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

it makes sense still. bards and tamers can walk around, because there "pets" do the fighting next to the monster.
the archer deals damage at range, therefor if i move i get less honor.

the system i am working on is how you suggest there though:
honor = monsters fame/100

use of poison -20%
first hit -20% (from total)
pet -20%
moving -20%

if all of the rules are followed exactly
honor +50%

using this system would be exact to my results. and 1000% more accurate than they are now

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

I re-tested honor gains with a provocation bard
1 in Fel and 1 in Tram
Along with the test I did this morning 3 times now I have come up with 17 honor kills to get 1 dot no matter whether it was in Fel with more fame or Tram with less fame

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

honor = monsters fame/100

The above may not be correct
I have 5 dots of honor filled from killing ettins

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

Something else I noticed on osi
If I honor an ettin just inside the entrance to where they spawn in Despise and provoke 2 of them (remember provocation will last 15 seconds on osi without the ettins having line of sight with me) and if I run up the stairs to the Despise entrance.If the ettin I honored dies I will get the fame and the karma but not the honor gain

I also tested this by staying on the same level of the dungeon
I marked a rune to the entrance to the next level
When the ettin was near death I recalled to the other end of the level and when the ettin died I received fame/karma and the honor gain

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

honor = monsters fame/100

The above may not be correct
I have 5 dots of honor filled from killing ettins

yeah thats right. 5 dots means you only have 2000 honor. The fame of an ettin is 3000, you can go at least to 7.5 dots.

the second post about the distance must mean that the honor can be given over a big distance. the co-ordinates of the map are greatly different from another lay of the dungeon to the outside world.

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

I have done nothing but kill ettins with this character and a few lizardmen for a report that is in testing
I no longer get fame from ettins but I do get honor

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

You can't ignore this any more I will not let you ignore it
You can't use ettin fame of 3000
Any creature that can give honor gains that spawns both in Felucca and any other facet you must add 30% to the fame/karma in your patch
I can still gain honor in Trammel (with over 3000 fame to my credit) killing ettins but I can't gain fame or karma
If I go to Felucca and kill ettins I will gain in fame karma and honor because fame and karma is higher for creatures in Felucca
Is this in the current demise code?

The first 7 shots are in Trammel Despise the remainder in Felucca

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

this patch has NOTHING to do with how much fame you gain. If you still gained honor in fel but not trammel, then it has something to do with it. However, this is nothing to do with virtues and must be reported as a new bug. We dont even know if it doesnt happen on demise

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

You can't ignore this any more I will not let you ignore it
You can't use ettin fame of 3000
Any creature that can give honor gains that spawns both in Felucca and any other facet you must add 30% to the fame/karma in your patch
I can still gain honor in Trammel (with over 3000 fame to my credit) killing ettins but I can't gain fame or karma
If I go to Felucca and kill ettins I will gain in fame karma and honor because fame and karma is higher for creatures in Felucca
Is this in the current demise code?

The first 7 shots are in Trammel Despise the remainder in Felucca

this patch has NOTHING to do with how much fame you gain. If you still gained honor in fel but not trammel, then it has something to do with it. However, this is nothing to do with virtues and must be reported as a new bug. We dont even know if it doesnt happen on demise

I said I still gain in Felucca and I showed proof in the screen shots

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

I said I still gain in Felucca and I showed proof in the screen shots

yes, yes you did. but you are also gaining in trammel too. If you didnt gain in trammel but did in felucca then its an issue.
Your fame doesnt mean you have that much honor either. Its variable.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

gawwdd just leave when i say hey to you at brit bank haha


okay tested it. Even though the fame given in felucca is higher, the honor isnt.
I just maxed out my honor on ettins in trammel, went to felucca killed an ettin got fame but no honor.
Honor is calculated on the monsters base amount of fame.
However, you do gain on paragons. If this doesnt occur on demise, its a paragon issue.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

In Virtue_updates.diff
1) honor isnt lost over time.
2) honor lasts 40 minutes on a target, or when the target dies. Not by running away or dying.
3) Tamers can gain, perhaps bards too( depending if the player is listsed as the master on a provoked creature, im not sure on that)
4) as long as a players honor is less than the fame, the player will gain at least 1 honor. (stops birds not giving honor)
5) Virtue balls are fixed for for virtues which require 22000 and 20000 for knight
6) Virtue status appear right
7) new variable added to playermobile.cs for 40 minutes honor period
8) Honor loses 1 dot upon use

In virtue_and_new_gain_sys
1) all of the above, plus a system I designed to match the content data of OSI for gains for all templates (warriors, archers, bard, tamer, mage)

Here is a clean patch for what i have fixed. If we get it tested and put in it will make it easier for me or anyone else to fix the other parts.
This should be okay for implementing, I just redone this to the new SVN. Cant test it locally, Im getting an error about SA.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

Everything in this is nearly done now. Just need one more thing.
Times for honor at seeker, follower and knight. How long does it last?

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

Here is 1 of the 3
Knight 5 minutes

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

cool. I got seeker too. its 30 seconds.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

case VirtueLevel.Seeker: return 30;
case VirtueLevel.Follower: return 90;
case VirtueLevel.Knight: return 300;

thats what the current code is. I guess its already correct. Who ever reported that as a bug should be shot haha.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

COMPLETE- ready for testing
this patch contains:
1) honor isnt lost over time.
2) honor lasts 40 minutes on a target, or when the target dies. Not by running away or dying.
3) Tamers can gain, perhaps bards too( depending if the player is listsed as the master on a provoked creature, im not sure on that)
4) as long as a players honor is less than the fame, the player will gain at least 1 honor. (stops birds not giving honor)
5) Virtue balls are fixed for for virtues which require 22000 and 20000 for knight
6) Virtue status appear right
7) new variable added to playermobile.cs for 40 minutes honor period
8) Honor loses 1 dot upon use
9) Gains to match osi for tamers/mages/archers/bards
10) embrace honor costs exactly one dot (at all levels)
11) "I honor you" has now gone. (just like osi)
12) All creatures give honor until fame is matched
13) Honor lasts as long as it does on OSI (30 seconds, 1 min 30, and 5 minutes) This was validated and was correct on demise anyway
14) Honor gump now appears when embracing